On Fri, Feb 21, 2014 at 12:04:03PM +0100, Takashi Iwai wrote:
At Fri, 21 Feb 2014 01:27:04 +0000, Patrick Welche wrote:
On Tue, Jan 14, 2014 at 02:23:01PM +0100, Takashi Iwai wrote:
BTW, about your patch: I don't think it's good to embed the endianness in asoundlib.h. It makes the header file appearing differently, depending on the architecture, which is rather confusing.
Is this more what you have in mind? (Less portable than autoconf, but not set at configure time.)
Yes, I supposed something like that.
The four files which included endian.h were:
- include/asoundlib-head.h
- include/local.h
- include/sound/type_compat.h
- src/pcm/pcm_file.c
The endian.h line(s) in asoundlib.h is now generated by configure.
Looks almost good, but I prefer seeing it just after #include <stdarg.h> instead of the middle in alsa/* inclusions.
Other than that, all look good to me. Could you fix and resubmit with your sign-off?
Version 2 with some of asoundlib-head.h moved to configure.in. (Fancy a patch to rename configure.in configure.ac, s/INCLUDES/AM_CPPFLAGS/?)
Cheers,
Patrick