22 Oct
2013
22 Oct
'13
2:26 p.m.
On 10/22/2013 02:01 PM, Mark Brown wrote:
On Fri, Oct 18, 2013 at 06:37:41PM +0300, Jyri Sarha wrote:
- TLV320AIC3X pins:
...
These should be documented in the CODEC binding and not in the card driver, that way this doesn't need to be replicated in every machine and any future software compatible devices can just work with the existing binding.
Ok, I'll remove the codec pins.
- ret = snd_soc_register_card(&evm_soc_card);
This should be using devm_snd_soc_register_card().
Ok, I'll move on top of your for-next branch and change it.
- /*
* If dtb is there, the devices will be created dynamically.* Only register platfrom driver structure.*/- if (of_have_populated_dt())
return platform_driver_register(&davinci_evm_driver);Why not register the driver unconditionally?
I am just trying touch the legacy davinci audio support as little as possible. Would registering the driver in non DT mode do some good?
Best regards, Jyri