On Tue, Aug 11, 2020 at 04:09:11PM +0200, Cezary Rojewski wrote:
On 2020-08-11 3:38 PM, Andy Shevchenko wrote:
On Tue, Aug 11, 2020 at 09:08:43PM +0800, kernel test robot wrote:
Hi Cezary,
I love your patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next] [also build test WARNING on sound/for-next v5.8 next-20200811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Cezary-Rojewski/ASoC-Intel-Catpt-Ly... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
To fix all these, please use %pR or %pr (I believe you want former rather than latter).
Thanks for the advice!
I'd like to keep format cohesive with the rest, though: restoring <type of context>: off 0x%08x size %d\n
%pr yields:
82.914316] snd_soc_catpt:catpt_restore_fwimage: catpt_adsp INT3438:00: restoring fwimage: [io 0x86470-0x86bbf flags 0xffffffffb2a27bf0]
Casting to (unsigned long long) should be fine, judging by /kernel/resource.c, yes?
No. The rule of thumb that if you cast for printf() something is really needs to be checked (and 99% wrong).
Use %pa as per printk-formats.rst.