On Mon, Dec 29, 2014 at 07:37:21PM +0200, Jyri Sarha wrote:
On 12/29/2014 06:52 PM, Mark Brown wrote:
So, I'm not seeing *any* interest here from any other HDMI users. This is a continuing theme with HDMI patches and is really very concerning, everyone appears to be working in their own bubbles coming up with their own things and ignoring everyone else's work - what little review I'm
I have not seen any significant new development since v7 of these patches. My comments for v6 were mostly[1] addressed and I can live with these changes, even develop this approach further if it gets merged.
OK, so this sort of feedback is really useful - even a qualified Reviwed-by is useful. Total silence could mean anything.
However, as a general note I see a need for a generic ASoC hdmi codec abstraction and I don't think this is generic enough. More of the audio specific implementation and HDMI standard specific things should be pushed away from the hdmi encoder driver (tda998x in this case) to the generic ASoC side hdmi codec driver (or library).
This is something I'm expecting, yes - what I don't have is a clear enough picture of how consistent the different hardware is in how it models these things.
[1] I personally do not like the hdmi_get_cdev() approach. I would rather go with only a library for registering from ASoC codec component under the HDMI encoder device or a completely separate device with only a reference to the HDMI encoder.
It does seem somewhat complicated, yes. I don't know if matches idioms for DRM somehow?