I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu chuansheng.liu@intel.com Signed-off-by: Baole Ni baolex.ni@intel.com --- sound/isa/sb/emu8000_patch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/isa/sb/emu8000_patch.c b/sound/isa/sb/emu8000_patch.c index 71d13c0..0dd7c20 100644 --- a/sound/isa/sb/emu8000_patch.c +++ b/sound/isa/sb/emu8000_patch.c @@ -24,7 +24,7 @@ #include <linux/moduleparam.h>
static int emu8000_reset_addr; -module_param(emu8000_reset_addr, int, 0444); +module_param(emu8000_reset_addr, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(emu8000_reset_addr, "reset write address at each time (makes slowdown)");