Hi,
On Sep 29 2018 06:27, Andre Guedes wrote:
While I was working on AAF plugin RFC v2 series [1], I spotted several leaks in some plugins when handling *_hw_constraint() error cases. This series fixes these issues.
Regards,
Andre
[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140290.h...
Andre Guedes (4): a52: Fix leaks when a52_set_hw_constraint() fails jack: Fix leaks when jack_set_hw_constraint() fails oss: Fix leaks when oss_hw_constraint() fails usb_stream: Fix leaks when us_set_hw_constraint() fails
a52/pcm_a52.c | 2 +- jack/pcm_jack.c | 1 + oss/pcm_oss.c | 2 +- usb_stream/pcm_usb_stream.c | 1 + 4 files changed, 4 insertions(+), 2 deletions(-)
I've reviewed all of the above patches.
Reviewed-by: Takashi Sakamoto o-takashi@sakamocchi.jp
I think it better for the plugins to use goto statement to aggregate error paths for releasing allocated objects but this is just for code cleanups.
Regards
Takashi Sakamoto