16 Nov
2017
16 Nov
'17
6:04 p.m.
On Thu, Nov 16, 2017 at 04:05:34PM +0000, Srinivas Kandagatla wrote:
Few Minor comments!!
All are helpful :)
+/**
- enum sdw_clk_stop_mode: Clock Stop modes
- @SDW_CLK_STOP_MODE_0: Slave can continue operation seamlessly on clock
- restart
- @SDW_CLK_STOP_MODE_1: Slave may have entered a deeper power-saving mode,
Should be MODE0 and MODE1.. here
yes thanks for spotting
+/**
- struct sdw_dpn_audio_mode: Audio mode properties for DPn
- @bus_min_freq: Minimum bus frequency, in Hz
- @bus_max_freq: Maximum bus frequency, in Hz
- @bus_num_freq: Number of discrete frequencies supported
- @bus_freq: Discrete bus frequencies, in Hz
- @bus_min_freq: Minimum sampling frequency, in Hz
Should be min_freq
- @bus_max_freq: Maximum sampling bus frequency, in Hz
Should be max_freq
- @bus_num_freq: Number of discrete sampling frequency supported
Should be num_freq
- @bus_freq: Discrete sampling frequencies, in Hz
Should be freq
yes, will fix
- @p15_behave: Slave behavior when the Master attempts a read to the Port15
- alias
- @lane_control_support:
?? do description here..
will add
--
~Vinod