Re: [PATCH v1 2/5] ASoC: codecs: ES8326: Change Hp_detect and volatile reg function

On Fri, Jul 14, 2023 at 11:24:50AM +0800, Zhu Ning wrote:

-static const struct regmap_range es8326_volatile_ranges[] = {

• regmap_reg_range(ES8326_HP_DETECT, ES8326_HP_DETECT),

-};

-static const struct regmap_access_table es8326_volatile_table = {

• .yes_ranges = es8326_volatile_ranges,
• .n_yes_ranges = ARRAY_SIZE(es8326_volatile_ranges),

-}; +static bool es8326_volatile_register(struct device *dev, unsigned int reg) +{

• switch (reg) {
• case ES8326_HPL_OFFSET_INI:
• case ES8326_HPR_OFFSET_INI:
• case ES8326_HPDET_STA:
• case ES8326_CTIA_OMTP_STA:
• case ES8326_CSM_MUTE_STA:

• return true;
  

That's clearly not just a name chnage, it's extending the set of volatile registers which should really be a separate patch - if you need to resend for some other reason please split it out, but if there's no other issues in the series don't worry here and just consider it next time.