4 Sep
2008
4 Sep
'08
4:43 p.m.
On Thu, Sep 04, 2008 at 04:22:06PM +0800, Bryan Wu wrote:
From: Cliff Cai cliff.cai@analog.com
Signed-off-by: Cliff Cai cliff.cai@analog.com Signed-off-by: Bryan Wu cooloney@kernel.org
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
Please fix the minor issues below as incremental patches for ease of review.
- switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
- case SND_SOC_DAIFMT_I2S:
break;- case SND_SOC_DAIFMT_LEFT_J:
ret = -EINVAL;break;- }
The SND_SOC_DAFIMT_LEFT_J: ought to be default: instead - there's more DAI formats than just that.
- if (!bf5xx_i2s.master) {
- /*
* TX and RX are not independent,they are enabled at the same time,* even if only one side is running.So,we need to configure both of* them in advance.** CPU DAI format:I2S, slave mode.*/
The indentation here is odd. Also, is the expecation that this configuration be done only once ever - nothing seems to clear the flag?