Re: [alsa-devel] [PATCH 1/3] ASoC: simple-card: set cpu dai clk in hw_params

29 May 2018

      On Tuesday, May 29, 2018 01:16 PM, Mark Brown wrote:
...
On Mon, May 28, 2018 at 09:35:01PM +0200, Daniel Mack wrote:
...
if (mclk_fs) {
   	mclk = params_rate(params) * mclk_fs;

if (dai_props->cpu_dai.clk)

	clk_set_rate(dai_props->cpu_dai.clk, mclk);

We're ignoring the return value here.
On purpose actually. Not all clocks might be settable, and in that case, 
this is a no-op. You think we should bail or warn?