18 Sep
2013
18 Sep
'13
12:41 p.m.
On Tue, Sep 17, 2013 at 11:10:24PM -0700, Olof Johansson wrote:
Please send things to the advertised maintainer addresses.
Commit 02b80773de37 (ASoC: rt5640: Add ACPI probing support.) causes a warning due to unreferenced variable on non-ACPI configs such as tegra_defconfig on ARM:
sound/soc/codecs/rt5640.c:2085:30: warning: 'rt5640_acpi_match' defined but not used [-Wunused-variable]
+#if CONFIG_ACPI static struct acpi_device_id rt5640_acpi_match[] = { { "INT33CA", 0 }, { }, }; MODULE_DEVICE_TABLE(acpi, rt5640_acpi_match); +#endif
Shouldn't the fix for this be to do the same as we're doing for the OF tables and have an acpi_match_ptr()? It seems like we're doing the same thing so we should be handling it in a similar fashion.