On Tue, Jun 05, 2012 at 11:15:59AM +0100, Russell King - ARM Linux wrote:
On Tue, Jun 05, 2012 at 11:14:13AM +0100, Mark Brown wrote:
That'd work too, of course (providing everyone has been implementing clk_put()). Though getting everyone on the same page with the clock API seems much more worthwhile if we can do it.
Why wouldn't clk_put() be implemented? Drivers call it just like clk_get().
Lazy people who can't be bothered, especially on platforms that do things like just return a pointer to a statically allocated clock or never really expect their drivers to be unloaded. Hopefully everyone filled in the blank but I've just got a general pessimism about relying on things like that.
The devm*() stuff should just be a layer on top of clk_get()/clk_put() and nothing more.
It is, yes.