On 5/28/19 2:15 PM, Jaroslav Kysela wrote:
I believe that we need to discuss this more.
Yep, absolutely!
Dne 28. 05. 19 v 18:59 Pierre-Louis Bossart napsal(a):
On 5/28/19 11:38 AM, Jaroslav Kysela wrote:
The same situation is for the SoC SOF firmware files (drivers are in kernel, firmware files are missing). Perhaps, we can release those files quickly in alsa-firmware and then migrate them slowly to linux-firmware.
for SOF there are 4 cases
- developers/integrators build from scratch themselves from the public
tree. 2. integrators build from scratch with their own secret sauce added. 3. distros want a binary since they don't want to build from source and/or don't have access to all the DSP tools 4. distros needs a binary signed with the Intel production key (e.g. to run on devices initially designed for Windows).
Do you mean that the firmware should be signed because the hardware is doing a check, if the hardware vendor enables it and rejects the unsigned binaries?
It depends on the platforms. Baytrail/Cherrytrail/Broadwell don't need any signature. Starting with Skylake, the firmware is authenticated and the DSP will not boot unless it's signed with the relevant key, but different platforms chose different protections. Most of the Windows platforms use a strong authentication based on a non-public 'production key', which prevents people from installing their own firmware. Other solutions such as Up Squared boards or 2019 Chromebooks use a public key that is already part of the SOF tree. Unfortunately I didn't find a way to detect which key is used, and it's not wise to try multiple keys since it adds a lot of latency on startup, so we are leaning to use DMI-based quirks to detect which key is used by what.
So far we were mostly dealing with case 1. Case 2 is allowed by the SOF permissive license and there's no need to look into this. We are planning releases for the last two cases, with a cadence aligned with kernel updates. It's not fully clear to me if the linux-firmware tree is the 'right' solution since ideally we'd want to have firmware, topology and UCM files released at the same time.
Do you plan to create a new package for this? I can eventually offer the space / docker build system on the ALSA server, if you like. The github releases work fine, too. The question is, if it's the right way. It seems that the firmware/topology files are read-only chunks used by the driver (standard usage) and the UCM config is for alsa-lib (the user space). It might make probably sense to add compatibility IDs to link/check the correct parts together at runtime and keep the standard (binary) code distribution for the most of users (linux-firmware / alsa-lib).
There is a connection mostly between topology and UCM: the device numbers used for the PCM streams have to match. If you add/remove a stream in the topology, then UCM will use numbers that aren't quite right. Same if you have a volume control used in UCM, you need to make sure that volume control is actually part of the topology.
In the past, we discussed about moving UCM files and topology out of the alsa-lib umbrella (and clarify what the license is for these configuration files), it's probably a good time to revisit this.
Speaking for distributions, we need to correctly identify the driver which will load the proper firmware files. From notes posted to the alsa-devel ML, it seems that there are three drivers for similar hardware (sound bridges) now and it is not easy to identify the proper driver, because the similar PCI ID is registered in all of them:
- legacy HDA
- sound/soc/intel
- sound/soc/sof/intel
Do not forget that the distributions include all driver modules in their universal kernels. It seems like a problem for the Intel hardware at the moment. Perhaps, you may give us some recommendations / hints.
Yes, I've started working on this, it's part of the same "distro enabling" discussion. In most of the cases, the legacy HDaudio driver can be used, unless there are DMICs attached. I submitted an RFC to try to add an auto-detection. I also added a build-time exclusion between SOF and SST drivers, and a smarter run-time detection I am still working on.
Totaly another topic is the on-demand installation of firmware files (and eventually ALSA configuration files). The linux-firmware package has over 180MB now and it's growing. It makes sense to install only useable firmware files - ommit the files for hardware / drivers which are not detected and used. It's probably a topic for linux-firmware rather then the ALSA project.
Indeed, for SOF we already have 6 or 7 firmwares for different SOCs and all the possible topologies.