-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 07/22/2014 07:44 PM, Felipe Balbi wrote:
On Tue, Jul 22, 2014 at 07:09:51PM +0200, Daniel Mack wrote:
On 07/04/2014 07:43 AM, Takashi Iwai wrote:
At Thu, 3 Jul 2014 20:15:28 +0200, Sebastian Reimers wrote:
The pcm playback and capture sample size format was fixed SNDRV_PCM_FMTBIT_S16_LE.
This patch respects also 16, 24 and 32 bit p_ssize and c_ssize values.
Signed-off-by: Sebastian Reimers sebastian.reimers@gmail.com
In general, this driver should check more on p_ssize. This can be any integer value passed as a module parameter. It should be cut to a sane value or give an error in the probe function when an invalid value is given. Ditto for p_srate and other parameters.
Also, I don't understand the logic of the code runtime->hw.period_bytes_min = 2 * uac2->p_prm.max_psize / runtime->hw.periods_min;
But this is mostly irrelevant with this patch, so for this patch: Reviewed-by: Takashi Iwai tiwai@suse.de
Felipe, are you fine with this one?
seems like I missed this one, do you mind if we take it during v3.17-rc and add Cc: stable ?
I guess that was what Sebastian intended :)
Thanks for taking care of it!
Daniel