On Thu, Nov 26, 2015 at 09:19:08AM +0000, Bard Liao wrote:
- {
.ident = "Google Terra",.callback = strago_quirk_cb,.matches = {DMI_MATCH(DMI_PRODUCT_NAME, "Terra"),},- },
It might make more sense to just have a single entry for all these Google platforms and extend this table rather than adding a complete new entry for every platform - they're all the same and it'd make the table smaller.
Totally agree. We are trying to simplify the code. The idea is using DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE") for all google project except a few projects with different HW design. We will use if else statement to match the projects with special HW design first and the
OK, that's a bit more than what I was thinking but sounds good - my thought was just to merge entries so there were more things in the .matches table.
general ones. Also, I think those can support DT/ACPI should have higher priority than DMI match, right?
That might lead to problems - one thing DMI gets used for is to override information from the firmware to fix bugs in what it's doing.