Re: [PATCH v2 4/4] ASoC: fsl: imx-rpmsg: Update to correct DT node

11 Mar 2024


      On 11/03/2024 08:33, Chancel Liu wrote:
...
...
...
@@ -127,6 +126,22 @@ static int imx_rpmsg_probe(struct platform_device
*pdev)
...
          goto fail;
  }



if (!strcmp(pdev->dev.platform_data, "rpmsg-micfil-channel"))


        np = of_find_node_by_name(NULL, "rpmsg_micfil");


else


        np = of_find_node_by_name(NULL, "rpmsg_audio");



Why do you create ABI on node names? Where is it documented? Why can't
you use phandles?
Best regards,
Krzysztof
Thanks for your reminder. Truly I shouldn't use undocumented bindings. I will
use “fsl,rpmsg-channel-name” to refine patch set. Please help review next
version.
Instead of hard-coding node names in the driver you want to put it in
"fsl,rpmsg-channel-name" property? I don't follow. I recommended instead
using phandles, care to address that?
Best regards,
Krzysztof

    

Krzysztof Kozlowski