Re: [PATCH 1/2] ASoC: dt-bindings: Add sample format conversion

On 29/07/2022 06:11, Sameer Pujar wrote:

...

diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml index b261d49..6decd73 100644 --- a/Documentation/devicetree/bindings/sound/simple-card.yaml +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml @@ -77,6 +77,17 @@ definitions: description: CPU to Codec rate channels. $ref: /schemas/types.yaml#/definitions/uint32

• convert-sample-format:
• description: CPU to Codec sample format.

•  Value    Format
  

•    0        S8
  

•    2        S16_LE
  

•    6        S24_LE
  

•    10       S32_LE
  

•    32       S24_3LE
  

• $ref: /schemas/types.yaml#/definitions/uint32

Wait, you now put the same property in four different places. Don't you have something which could be shared?

There is no shared schema between simple-card.yaml and others. I will have to create a new doc to share these definitions.

OK

Best regards, Krzysztof