On 14/08/2021 7:41 am, Takashi Iwai wrote:
On Fri, 13 Aug 2021 08:10:47 +0200, Takashi Iwai wrote:
On Thu, 12 Aug 2021 20:34:33 +0200, Vitaly Rodionov wrote:
From: Stefan Binding sbinding@opensource.cirrus.com
During reboot, when the CS42L42 powers down, pops and clicks may occur due to the codec not being shutdown gracefully. This can be fixed by going through the suspend sequence, which shuts down the codec cleanly inside the reboot_notify hook, which is called on reboot.
Signed-off-by: Stefan Binding sbinding@opensource.cirrus.com Signed-off-by: Vitaly Rodionov vitalyr@opensource.cirrus.com
I hold this one for now, as there is a fix series that deprecates the reboot_notify callback of HD-audio by forcibly doing runtime-suspend at shutdown. Please check the three patches in https://bugzilla.kernel.org/show_bug.cgi?id=214045
I'm going to submit those soon in anyway.
Hi Takashi,
Thanks for letting us know. We have tested against for-next branch and we have an issue.
Loud pops on reboot. It looks like suspend have never been called on reboot or shutdown for us.
The removal of reboot_notifier landed in my for-next branch now. Please rebase and adapt the changes appropriately. In short, the runtime suspend is applied at the shutdown, so the workaround is needed only for suspend.
thanks,
Takashi