A wrong, uninitialized variable is referred as the size to check in tplg_parse_data_hex(). Spotted by gcc warning: data.c: In function ‘tplg_parse_data_hex’: data.c:228:5: warning: ‘esize’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (esize > TPLG_MAX_PRIV_SIZE) { ^ data.c:211:12: note: ‘esize’ was declared here int size, esize, off, num; ^
Signed-off-by: Takashi Iwai tiwai@suse.de --- src/topology/data.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/topology/data.c b/src/topology/data.c index 4ee1f8a15f95..370c0faead36 100644 --- a/src/topology/data.c +++ b/src/topology/data.c @@ -225,8 +225,8 @@ static int tplg_parse_data_hex(snd_config_t *cfg, struct tplg_elem *elem, size = num * width; priv = elem->data;
- if (esize > TPLG_MAX_PRIV_SIZE) { - SNDERR("error: data too big %d\n", esize); + if (size > TPLG_MAX_PRIV_SIZE) { + SNDERR("error: data too big %d\n", size); return -EINVAL; }