On Tue, May 25, 2021 at 11:15:17PM +0100, Phillip Potter wrote:
On Tue, May 25, 2021 at 10:49:44PM +0100, Mark Brown wrote:
Now I've looked at the patch I don't think it's appropriate for stable, it's essentially equivalent to a patch that adds -Werror
So I frankly don't have the experience to disagree with you :-) Your reasoning certainly seems sound to me. My original motivation for the patch (after discussion with others within the mentorship process) was that some other sound SoC drivers do this, an example being the Ux500. I defer to the decision of the community as a whole of course, and am happy with whatever is decided.
Right, so there's multiple bits here - there's checking at all, there's adding the checks to mainline and there's backporting them to stable. For stable we want to be fairly conservative about what we're backporting since we want people to be able to just update without worrying about things breaking on them so something that increases the severity of existing checks is particularly risky, if the code were already there and people would've seen any issues it causes when integrating the kernel it's a different story since the risks are different.