Hi Mark,
On Thu, Dec 5, 2013 at 7:55 PM, Mark Brown broonie@kernel.org wrote:
From: Mark Brown broonie@linaro.org
In preparation for using the dmaengine helpers in ASoC rather than the dmaengine wrappers for the Samsung API wrap the configuration of dma_data. The dmaengine code expects different data to that used by the legacy API.
Signed-off-by: Mark Brown broonie@linaro.org
This will need merging with the fix patch I sent earlier, I'l do that assuming this is OK.
[snip]
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index a5cbdb4f1655..eab0050d4579 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -946,8 +946,11 @@ static int samsung_i2s_dai_probe(struct snd_soc_dai *dai) struct i2s_dai *i2s = to_info(dai); struct i2s_dai *other = i2s->pri_dai ? : i2s->sec_dai;
if (other && other->clk) /* If this is probe on secondary */
if (other && other->clk) { /* If this is probe on secondary */samsung_asoc_init_dma_data(dai, &other->sec_dai->dma_playback,NULL); goto probe_exit;}
This is done in your earlier patch " ASoC: samsung: Ensure DMA data is initialised for secondary DAI ". Was it done on purpose or by mistake in this patch?
I think you also told to include a patch for reinitialization of the dma_data in i2s_hw_params. If you are in the process of debugging some bug as you mentioned earlier you can ignore this comment. Otherwise it is just a reminder.
Thanks Padma