5 Oct
2011
5 Oct
'11
12:39 p.m.
2011/10/5 Mark Brown broonie@opensource.wolfsonmicro.com:
On Wed, Oct 05, 2011 at 06:16:49PM +0800, Axel Lin wrote:
Current code has off-by-one bug of checking WM8990_RESET. Besides, according to wm8990 datasheet (2-wire serial control mode): A control word consists of 24 bits. The first 8 bits are address bits, the remaining 16 bits are data bits. Current code uses 7 bits address bits and 9 bits data bits which is incorrect.
We should just convert drivers like this to snd_soc_cache_sync().
Yes. It would be better convert it to snd_soc_cache_sync(). Just think this patch may be useful for 3.1 or earlier kernel version.
Axel