Hi Mohammad,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next] [also build test WARNING on next-20230201] [cannot apply to tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.2-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mohammad-Rafi-Shaik/ALSA-comp... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230201134947.1638197-5-quic_mohs%40quicinc.com patch subject: [PATCH 04/14] ASoC: q6dsp: audioreach: Add support for compress offload commands config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230201/202302012309.BtyJn8FN-lkp@i...) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6a2982489303bcf32b927da80e4baf... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mohammad-Rafi-Shaik/ALSA-compress-Update-compress-set-params-for-gapless-playback/20230201-215622 git checkout 6a2982489303bcf32b927da80e4baffae58437e0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash sound/soc/qcom/qdsp6/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
sound/soc/qcom/qdsp6/audioreach.c:1262:5: warning: no previous prototype for 'audioreach_send_u32_param' [-Wmissing-prototypes]
1262 | int audioreach_send_u32_param(struct q6apm *apm, struct audioreach_module *module, | ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/audioreach_send_u32_param +1262 sound/soc/qcom/qdsp6/audioreach.c
1261
1262 int audioreach_send_u32_param(struct q6apm *apm, struct audioreach_module *module,
1263 uint32_t param_id, uint32_t param_val) 1264 { 1265 struct apm_module_param_data *param_data; 1266 struct gpr_pkt *pkt; 1267 uint32_t *param; 1268 int rc, payload_size; 1269 void *p; 1270 1271 payload_size = sizeof(uint32_t) + APM_MODULE_PARAM_DATA_SIZE; 1272 p = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0); 1273 if (IS_ERR(p)) 1274 return -ENOMEM; 1275 1276 pkt = p; 1277 p = p + GPR_HDR_SIZE + APM_CMD_HDR_SIZE; 1278 1279 param_data = p; 1280 param_data->module_instance_id = module->instance_id; 1281 param_data->error_code = 0; 1282 param_data->param_id = param_id; 1283 param_data->param_size = payload_size - APM_MODULE_PARAM_DATA_SIZE; 1284 1285 p = p + APM_MODULE_PARAM_DATA_SIZE; 1286 param = p; 1287 *param = param_val; 1288 rc = q6apm_send_cmd_sync(apm, pkt, 0); 1289 1290 kfree(pkt); 1291 1292 return rc; 1293 } 1294 EXPORT_SYMBOL_GPL(audioreach_send_u32_param); 1295