Re: [alsa-devel] [PATCH v6 9/9] davinci: USB1.1 support for Omapl138-Hawkboard

Hi Victor,

On Fri, Oct 29, 2010 at 20:40:45, vm.rod25@gmail.com wrote:

From: Victor Rodriguez victor.rodriguez@sasken.com

This patch adds USB1.1 support for the Hawkboard-L138 system

Signed-off-by: Victor Rodriguez victor.rodriguez@sasken.com

+static int hawk_usb_ocic_notify(da8xx_ocic_handler_t handler) +{

• int irq         = gpio_to_irq(DA850_USB1_OC_PIN);
  

• int error       = 0;
  

• if (handler != NULL) {
  

•         hawk_usb_ocic_handler = handler;
  

•         error = request_irq(irq, omapl138_hawk_usb_ocic_irq,
  

•                                 IRQF_DISABLED | IRQF_TRIGGER_RISING |
  

•                                 IRQF_TRIGGER_FALLING,
  

•                                 "OHCI over-current indicator", NULL);
  

•         if (error)
  

•                 pr_err(KERN_ERR "%s: could not request IRQ to watch "
  

•                         "over-current indicator changes\n", __func__);
  

• } else
  

•         free_irq(irq, NULL);
  

Per Documentation/CodingStyle, else should have braces too.

+static struct da8xx_ohci_root_hub omapl138_hawk_usb11_pdata = {

• .set_power      = hawk_usb_set_power,
  

• .get_power      = hawk_usb_get_power,
  

• .get_oci        = hawk_usb_get_oci,
  

• .ocic_notify    = hawk_usb_ocic_notify,
  

• /* TPS2087 switch @ 5V */
  

Do we have this part on the hawkboard as well?

[...]

+static __init void omapl138_hawk_usb_init(void) +{

• int ret;
  

• u32 cfgchip2;
  

• ret = davinci_cfg_reg_list(da850_hawk_usb11_pins);
  

• if (ret) {
  

•         pr_warning("%s: USB 1.1 PinMux setup failed: %d\n",
  

•                 __func__, ret);
  

•         return;
  

• }
  

• /*
  

•  * Setup the Ref. clock frequency for the HAWK at 24 MHz.
  

•  */
  

No need of multi-line comment style here.

Sorry about the piecemeal review (you really generated new versions quickly). That is all I have on this series.

Also, you are CCing a whole lot of folks on each patch. Instead, you can automate CCing the relevant folks using --cc-cmd=<command> option of git-send-email

Use --cc-cmd="scripts/get_maintainer.pl --pattern-depth=2 -s" to generate list of relevant CCs.

Example:

scripts/get_maintainer.pl -f arch/arm/mach-davinci/board-omapl138-hawk.c --pattern-depth=2 -s

gives:

Kevin Hilman khilman@deeprootsystems.com Russell King linux@arm.linux.org.uk davinci-linux-open-source@linux.davincidsp.com linux-arm-kernel@lists.infradead.org

Recently Kevin requested all patches to CC Linux ARM Kernel mailing list so this should be OK.

scripts/get_maintainer.pl -f sound/soc/davinci/davinci-evm.c --pattern-depth=2 -s

gives:

Liam Girdwood lrg@slimlogic.co.uk Mark Brown broonie@opensource.wolfsonmicro.com alsa-devel@alsa-project.org

This is as per what Liam and Mark have been asking for.

Also, use --dry-run with git-send-email before sending actual emails to make sure the To and CC lists look good.

Thanks, Sekhar