On Tue, May 30, 2017 at 08:06:38PM +0300, Andy Shevchenko wrote:
On Tue, May 30, 2017 at 7:51 PM, Douglas Anderson dianders@chromium.org wrote:
In commit 9a075265c6dc ("ASoC: Intel: sst: Remove unused function sst_restore_shim64()"), we deleted the sst_restore_shim64() since it was never used. ...but a quick look at the code shows that we should also be able to remove the sst_save_shim64() function and the structure members we were storing data in.
Once we delete sst_save_shim64() there are no longer any users of the 'sst_shim_regs64' structure. That means we can delete it completely and also avoid allocating memory for it. This saves a whopping 136 bytes of devm allocated memory. We also get the nice benefit of avoiding an error path in the init code.
Note that the saving code that we're removing (and the comments talking about how important it is to do the save) has been around since commit 336cfbb05edf ("ASoC: Intel: mrfld- add ACPI module").
I like it! Reviewed-by: Andy Shevchenko andy.shevchenko@gmail.com
Acked-by: Vinod Koul vinod.koul@intel.com
P.S. Perhaps there are more leftovers or dead code?
Hope not :) This was due to restore not required eventually. Somehow save was left pending.