I agree, I'll adapt Librem 5 dts to follow original convention and resend.
-------- Původní zpráva -------- Odesílatel: Rob Herring robh@kernel.org Odesláno: 8. listopadu 2021 21:04:44 UTC Komu: David Heidelberg david@ixit.cz Kopie: Liam Girdwood lgirdwood@gmail.com, Mark Brown broonie@kernel.org, - kernel@puri.sm, ~okias/devicetree@lists.sr.ht, phone-devel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Předmět: Re: [PATCH v2] dt-bindings: sound: gtm601: convert to YAML
On Sat, Oct 30, 2021 at 02:17:52PM +0200, David Heidelberg wrote:
Convert GTM601 binding to the YAML format.
Signed-off-by: David Heidelberg david@ixit.cz
v2:
- add #sound-dai-cells
- put kernel@puri.sm into maintainers
.../devicetree/bindings/sound/gtm601.txt | 19 ---------- .../devicetree/bindings/sound/gtm601.yaml | 36 +++++++++++++++++++ 2 files changed, 36 insertions(+), 19 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/gtm601.txt create mode 100644 Documentation/devicetree/bindings/sound/gtm601.yaml
diff --git a/Documentation/devicetree/bindings/sound/gtm601.txt b/Documentation/devicetree/bindings/sound/gtm601.txt deleted file mode 100644 index efa32a486c4a..000000000000 --- a/Documentation/devicetree/bindings/sound/gtm601.txt +++ /dev/null @@ -1,19 +0,0 @@ -GTM601 UMTS modem audio interface CODEC
-This device has no configuration interface. The sample rate and channels are -based on the compatible string
- "option,gtm601" = 8kHz mono
- "broadmobi,bm818" = 48KHz stereo
-Required properties:
- compatible : one of
- "option,gtm601"
- "broadmobi,bm818"
-Example:
-codec: gtm601_codec {
- compatible = "option,gtm601";
-}; diff --git a/Documentation/devicetree/bindings/sound/gtm601.yaml b/Documentation/devicetree/bindings/sound/gtm601.yaml new file mode 100644 index 000000000000..e81a6aa75522 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/gtm601.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/gtm601.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: GTM601 UMTS modem audio interface CODEC
+maintainers:
- kernel@puri.sm
+description: >
- This device has no configuration interface. The sample rate and channels are
- based on the compatible string
+properties:
- compatible:
- oneOf:
- items:- const: broadmobi,bm818- const: option,gtm601
This does not match what the binding originally said. And generally this combined with the one below should never be valid.
- items:- enum:- broadmobi,bm818 # 48 kHz stereo- option,gtm601 # 8 kHz mono- '#sound-dai-cells':
- const: 0
+additionalProperties: false
+examples:
- |
- gtm601_codec {
compatible = "option,gtm601";- };
-- 2.33.0