Re: [alsa-devel] [PATCH] ASoC: mc13783: add mixer controls

Hi!

On Wed, Oct 09, 2013 at 04:13:36PM +0100, Mark Brown wrote:

On Wed, Oct 09, 2013 at 05:01:44PM +0200, Steffen Trumtrar wrote:

...

+static const char * const mc13783_alsp[] = {"Off", "Codec", "Right"};

+static const char * const mc13783_ahs[] = {"Codec", "Mixer"};

What are these - these look like they might be DAPM rather than regular controls?

Looks like you are right. Will fix.

...

• SOC_SINGLE("Headset Amp Right Switch", MC13783_AUDIO_RX0, 9, 1, 0),
• SOC_SINGLE("Headset Amp Left Switch", MC13783_AUDIO_RX0, 10, 1, 0),

I would expect these to be stereo controls rather than two mono controls?

Okay.

...

• SOC_ENUM("Line out Amp Switch", mc13783_enum_arxout),

Switches shouldn't be enums.

Hm, would "Line out Amp Source" be correct then? Or just "Line out Amp"? I'm not really getting the documentation in that regard.

...

• SOC_SINGLE("Codec Capture Mix Switch", MC13783_AUDIO_RX0, 21, 1, 0),

CODEC and Codec seem to be getting mixed in the file.

Okay. I will fix that.

Thanks, Steffen