30 Sep
2020
30 Sep
'20
9:19 a.m.
Dne 30. 09. 20 v 7:51 Hui Wang napsal(a):
If the caller of enable_callback_mst() passes a cb func, the callee function will malloc memory and link this cb func to the list unconditionally. This will introduce problem if caller is in the hda_codec_ops.init() since the init() will be repeatedly called in the codec rt_resume().
So far, the patch_hdmi.c and patch_ca0132.c call enable_callback_mst() in the hda_codec_ops.init().
Won't be better to handle this double invocation at the callback call time? I believe that some refcounting and pointing to one allocated callback structure for all instances is better.
Jaroslav
--
Jaroslav Kysela perex@perex.cz
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.