At Mon, 17 Jun 2013 11:06:18 +0200, David Henningsson wrote:
On 06/17/2013 10:06 AM, Takashi Iwai wrote:
At Mon, 17 Jun 2013 09:58:46 +0200, David Henningsson wrote:
On 06/17/2013 09:49 AM, Takashi Iwai wrote:
At Tue, 11 Jun 2013 11:06:49 +0200, David Henningsson wrote:
These headset jacks keep coming in on more and more platforms, and it's possible I don't catch them all. Make it easier to test and verify by making models.
Signed-off-by: David Henningsson david.henningsson@canonical.com
The patch does more than it says; it reformats and modifies HD-Audio-Models.txt. If it's intended to be merged to 3.10 kernel, please make things as minimal as possible, then prepare another patch for cleaning up the whole document.
Given Linus's latest "don't send me non-critical stuff" comment [1], I was expecting you to defer this patch to 3.11 anyway. If you can merge the first patch (the one that adds three headset IDs) to 3.10, that would be appreciated though.
The addition of IDs are real fixes, so they should go to 3.10.
Then the only question is how annoying for you if the additional model string would be missing. If it doesn't matter, I can postpone it, of course.
It would be helpful to have the models in 3.10 but not an absolute requirement.
Also, I'm not sure how to split this patch, all reformat/modifications are just because of the documentation of the added models.
Simply add three lines to HD-Audio-Models.txt together with three lines addition to patch_realtek.c. Total six lines. Don't be bothered by the aligned tabs.
Ok, I've now splitted that patch into two and just sent the result.
Thanks, applied new patches now.
Takashi