At Tue, 20 Nov 2007 09:25:36 +0000, Mark Brown wrote:
From: Liam Girdwood liam@localhost.localdomain
I suppose the author is Liam, right? It's a bit strange that his sign-off appears in the middle, then...
Signed-off-by: Marc Mulcahy marc@levelstar.com Signed-off-by: Graeme Gregory gg@opensource.wolfsonmicro.com Signed-off-by: Liam Girdwood lg@opensource.wolfsonmicro.com Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
(snip)
+static int mixer_event(struct snd_soc_dapm_widget *w,
- struct snd_kcontrol *kcontrol, int event)
+{
...
- if (l & 0x1 || r & 0x1)
I'd suggest to put parentheses around bit-ops.
+static int wm9713_set_dai_clkdiv(struct snd_soc_codec_dai *codec_dai,
int div_id, int div)+{
...
+};
Remove semicolon.
+#define WM9713_PCM_FORMATS \
- (SNDRV_PCM_FORMAT_S16_LE | SNDRV_PCM_FORMAT_S20_3LE | \
SNDRV_PCM_FORMAT_S24_LE)
Is it S24_LE or S24_3LE? I see S24_LE in other codec drivers, but am not pretty sure whether I checked it...
Takashi