Re: [alsa-devel] [PATCH V4 2/2] ASoC: SPEAr spdif_out: Add spdif out support

On Tue, Jul 03, 2012 at 05:24:59PM +0530, Rajeev Kumar wrote:

+static int spdif_out_mute;

This should be part of your driver data, not static data.

+int spdif_soc_dai_probe(struct snd_soc_dai *dai) +{ + struct snd_soc_card *card = dai->card; + struct snd_soc_pcm_runtime *rtd = card->rtd; + struct snd_soc_codec *codec = rtd->codec; + + return snd_soc_add_codec_controls(codec, spdif_out_controls, + ARRAY_SIZE(spdif_out_controls));

snd_soc_add_dai_controls().