Re: [PATCH] ASoC: dt-bindings: nau8824: Convert to dtschema

On 5/14/2023 2:38 AM, Krzysztof Kozlowski wrote:

On 12/05/2023 14:01, David Lin wrote:

...

Convert the NAU8824 audio CODEC bindings to DT schema.

Signed-off-by: David Lin CTLIN0@nuvoton.com

Thank you for your patch. There is something to discuss/improve.

...

• nuvoton,sar-threshold-num:
• $ref: /schemas/types.yaml#/definitions/uint32
• description:

•  Number of buttons supported.
  

• minimum: 1
• maximum: 4
• default: 4
• nuvoton,sar-threshold:
• $ref: /schemas/types.yaml#/definitions/uint32-array
• description:

•  Impedance threshold for each button. Array that contains up to 8 buttons
  

•  configuration. SAR value is calculated as
  

•  SAR = 255 * MICBIAS / SAR_VOLTAGE * R / (2000 + R) where MICBIAS is
  

•  configured by 'nuvoton,micbias-voltage', SAR_VOLTAGE is configured by
  

•  'nuvoton,sar-voltage', R - button impedance.
  

•  Refer datasheet section 10.2 for more information about threshold
  

•  calculation.
  

• minItems: 1
• maxItems: 4

Your description mentions 8 buttons, so maybe it should be 8 here? Or description needs a fix?

Driver just handle maxima 4 buttons for general application, but the the above description is truly hardware capability with 8 buttons support.

...

• items:

•  minimum: 0
  

•  maximum: 255
  

• nuvoton,sar-hysteresis:
• $ref: /schemas/types.yaml#/definitions/uint32
• description:

•  Button impedance measurement hysteresis.
  

• default: 0

Best regards, Krzysztof

________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.