Hi
Hi Gustavo,
On Mon, Apr 08, 2019 at 10:20:25PM -0500, Gustavo A. R. Silva wrote:
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index c7410bbfd2af..bad0dfed6b68 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct
snd_soc_dai *dai, int clk_id,
break; case ESAI_HCKT_EXTAL: ecr |= ESAI_ECR_ETI;Also, you should use a simple assignment operator "=" instead of "|=" in both cases.
The result is same for "=" and "|=", because there is "ecr = 0" in beginning of This function.
Following that same logic, then why not use "+=" instead?
The point is: is "|=" or any other assignment operator other than "="
necessary?
The answer in this case is: no, it is not. So, go for the simple one and avoid any unnecessary confusion.
I would like to keep "|=" here, just in case that someday it'd be easier to insert something to ecr before this chunk. So please get easy on this one.
Thanks Nicolin
Thanks for reviewing, I will send v2.
Best regards Wang shengjiu