Re: [alsa-devel] [PATCH 07/28] ASoC: soc-core: don't check widget for snd_soc_dapm_new_controls()

On Mon, Aug 05, 2019 at 09:35:58PM -0700, Ranjani Sridharan wrote:

On Tue, 2019-08-06 at 10:28 +0900, Kuninori Morimoto wrote:

...

• if (card->dapm_widgets)

• snd_soc_dapm_new_controls(&card->dapm, card-
  

...

dapm_widgets,

• 			  card->num_dapm_widgets);
  

• snd_soc_dapm_new_controls(&card->dapm, card->dapm_widgets,

• 		  card->num_dapm_widgets);
  

Should the return value be checked here?

Preexisting bug but yes.