On Wed, Sep 28, 2011 at 10:02 PM, Axel Lin axel.lin@gmail.com wrote:
The callers use the return value of max98095_get_bq_channel as array index to access max98095->dai[] array. Add BUG() assertion for out of bound access of max98095->dai[] array.
Signed-off-by: Axel Lin axel.lin@gmail.com
sound/soc/codecs/max98095.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c index 668434d..973c02d 100644 --- a/sound/soc/codecs/max98095.c +++ b/sound/soc/codecs/max98095.c @@ -1998,6 +1998,7 @@ static int max98095_get_bq_channel(const char *name) return 0; if (strcmp(name, "Biquad2 Mode") == 0) return 1;
- BUG();
return -EINVAL;
below better? BUG_ON(strcmp(name, "Biquad2 Mode")); return 1;
Or BUG_ON(channel < 0) in caller
}
-- 1.7.4.1
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/