On Thu, 15 Jan 2009 21:40:41 +0000 Mark Brown broonie@sirena.org.uk wrote:
On Thu, Jan 15, 2009 at 04:17:00PM -0500, Hugo Villeneuve wrote:
Mark Brown broonie@sirena.org.uk wrote:
Sounds like that should be fixed instead, then?
If someone wants to fix it, fine. I tried but couldn?t find what is wrong. Maybe the person who added that piece of code (not me) should fix it...
It was added by David Brownell to prevent the module being used on the wrong hardware, which is perfectly reasonable. The machine_is_foo() tests are a very standard part of the ARM infrastructure and are widely used - if they're not working that's where the fix is. Are you sure that your .config has MACH_SFFSDR set? There appears to be no mainline support for the core machine so you'd have to have patched that in...
I just found the cause. I created the SFFSDR machine on the ARM website, and this automatically defined the macro CONFIG_MACH_SFFSDR, and not CONFIG_MACH_DAVINCI_SFFSDR like it is currently in the Kconfig.
I will submit a patch to rename CONFIG_MACH_DAVINCI_SFFSDR to CONFIG_MACH_SFFSDR in the Kconfig file.
Thank-you everyone for your help.
Hugo.
--------------- Hugo Villeneuve www.hugovil.com ---------------