hello,
On Mon, Jul 12, 2010 at 1:12 PM, Peter Ujfalusi peter.ujfalusi@nokia.com wrote:
On Tuesday 06 July 2010 01:51:20 ext Grazvydas Ignotas wrote:
On Tue, Jul 6, 2010 at 12:13 AM, peter.ujfalusi@nokia.com wrote:
What I can think of is: If only one (the master) stream has been opened, and the stream is not running (the pcm_trigger has not been called yet), than we could allow reconfiguration of the codec. Might work OK, but it might cause some problems under different scenario.
This sounds good to me, I wonder what that different scenario could be.
It's hard to say what scenario, but if we start to fix application bugs in driver level, than surely it will not going to be an easy task.
Just to clarify, from OSS point of view the app is correct (and rather typical), it first sets sample format, then rate and channel count. There is no way to set all of these at once using OSS API from what I understand.
Is it worth trying implementing that (i.e. would such patch be even considered)?
As of it now, I'm not planning to add workaround to this, since I can not really test if it is working correctly.
If you can build a kernel with OSS emulation enabled it's trivial to test, just run 'mplayer -ao oss' or build the test I sent before (just include linux/souncard.h, no libraries required).
Also I just came back from holiday, and my mailbox is quite full, so do not expect that I can even take a look at this in the near future.
Having said that.. since I do care about the twl4030 codec driver (and it's users), I will try to allocate time to fix it for you.
Thanks!
On Tue, Jul 6, 2010 at 12:40 AM, Liam Girdwood lrg@slimlogic.co.uk wrote:
Please port your app to ALSA, it's really the easiest option (look at aplay.c for programming sequence).
The problem is not new apps, but legacy ones. Pandora is spiritual successor of Gamepark/GPH devices, which only had OSS drivers, so we have many apps/games outputing through OSS, some of them without source available. We will have to provide userspace OSS emulation at least, and in-kernel OSS emulation is attractive because of performance reasons.
I would advice to use the userspace emulation for now. There might be kernel level fix for this, but it will take time.
-- Péter