3 Dec
2012
3 Dec
'12
1:18 a.m.
Hi Daniel
Thank you for checking this patch.
- of_property_read_string(np, "cinfo,name", &cinfo->name);
- of_property_read_string(np, "cinfo,card", &cinfo->card);
- of_property_read_string(np, "cinfo,cpu_dai", &cinfo->cpu_dai);
- of_property_read_string(np, "cinfo,codec", &cinfo->codec);
- of_property_read_string(np, "cinfo,platform", &cinfo->platform);
- of_property_read_string(np, "cinfo,codec_dai", &cinfo->codec_dai);
CPUs, codecs and platforms should be referenced by phandles rather than by string. The ASoC core is well prepared for this, by using the dai_link's *_of_node members.
OK. I fix it in v2
@@ -62,7 +140,7 @@ static int asoc_simple_card_probe(struct platform_device *pdev) !cinfo->codec || !cinfo->platform || !cinfo->codec_dai) {
dev_err(&pdev->dev, "insufficient asoc_simple_card_info settings\n");
dev_err(dev, "insufficient asoc_simple_card_info settings\n");That's an unrelated change that should probably go into a separate commit.
OK. I'll do it in v2
Best regards --- Kuninori Morimoto