11 Apr
2011
11 Apr
'11
3:35 p.m.
On Mon, Apr 11, 2011 at 08:53:18PM +0800, Lu Guanqun wrote:
Please *always* delete irrelevant context from replies - it makes it much easier to find the new text.
On Mon, Apr 11, 2011 at 01:30:00PM +0800, Rajeev Kumar wrote:
+config SND_SOC_STA529
tristate
depends on I2C
I see many drivers depend on I2C, but they don't add the line above. Any reasons for it?
It won't actually do anything - select ignores depends.
+static int __init sta529_modinit(void) +{
int ret = 0;
ret = i2c_add_driver(&sta529_i2c_driver);
As an idiom, I often see the above code surrounded with an #ifdef, see below code snippet from sound/soc/codecs/wm8974.c
This is only for devices that support more than one control interface. If the device only supports one control interface there is no need to make anything conditional.