Re: [alsa-devel] [PATCH 4/4] ASoC: tlv320aic3x: Let the codec hit SND_SOC_BIAS_OFF when idle

On Fri, Sep 10, 2010 at 02:23:32PM +0300, Jarkko Nikula wrote:

• regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);

• if (aic3x->power)

• regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies),
  

• 		       aic3x->supplies);
  

This looks suspicious - doesn't it mean that the enable/disables won't be balanced any more? I'd expect to either see the disable being uncondtional or the power flag being updated. I could be missing something, though.