5 May
2017
5 May
'17
12:02 p.m.
On Fri, May 5, 2017 at 12:57 PM, Christoph Hellwig hch@lst.de wrote:
On Fri, May 05, 2017 at 12:50:31PM +0300, Amir Goldstein wrote:
To complete the picture for folks not cc'ed on my patches, xfs use case suggests there is also justification for the additional helpers:
uuid_is_null() / uuid_equal() guid_is_null() / guid_equal()
The is_null is useful and I bet we'll find other instances. I'm not sure _equals really adds much value over the existing _cmp helpers, but on the other hand they are so trivial that we might as well add them.
Exactly. The fact that not only xfs used the same helper name (drivers/md/md.c) suggests that it useful.
The other thing XFS has is uuid_copy.
Andy already listed uuid_copy.