On Mon, Oct 20, 2014 at 07:36:32PM +0200, Lars-Peter Clausen wrote:
Changing a single control on a 5 input mixer while the system is idle:
Power Path Neighbour
Before: 2 25 32 After~1: 2 12 30 After: 2 1 2
Cumulative numbers for switching the audio profile which changes 7 controls while the system is idle:
Power Path Neighbour
Before: 16 141 188 After~1: 16 80 170 After: 16 7 23
This series is all basically OK, a couple of small comments one of which was very near the start of the series or I'd have applied more.
Just as a general comment the numbers you're showing here are all for very small use cases and while they do show an order of magnitude improvement if they do scale out (it looks like this is mostly linear or constant factor gains but some of those are scale with the total number of widgets or paths which can be interesting) since that makes things much more exciting. It's also good (though not at all essential) to show the benchmarks on individual commits since this both keeps them around and helps people trying to solve performance problems in production find relevant upstream optimisations to backport.