On 04/09/2014 01:12 PM, Krzysztof Kozlowski wrote:
On śro, 2014-04-09 at 12:57 +0200, Lars-Peter Clausen wrote:
On 04/09/2014 09:21 AM, Krzysztof Kozlowski wrote:
Fix following Sparse warning: sound/soc/soc-core.c:252:20: error: incompatible types in comparison expression (different type sizes)
Signed-off-by: Krzysztof Kozlowski k.kozlowski@samsung.com
sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 051c006281f5..41f6178249df 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -249,7 +249,7 @@ static ssize_t codec_reg_write_file(struct file *file, struct snd_soc_codec *codec = file->private_data; int ret;
- buf_size = min(count, (sizeof(buf)-1));
- buf_size = min(count, (size_t)(sizeof(buf)-1));
But shouldn't the type of sizeof already be size_t?
Hmmm... yes it should. It looks like a false positive from Sparse so the commit message should be rather "Suppress" than "Fix".
I'm pretty sure it is a bug in sparse, we shouldn't suppress those, but rather fix them in sparse itself.