On Sat, 08 Dec 2018 01:00:37 +0100, Pierre-Louis Bossart wrote:
This patchset depends on the "ASoC: Intel: Skylake: probe and Kconfig simplifications" series.
Add the same logic based on PCI class/subclass/prog-if in the HDaudio legacy probe, and add a module parameter to bypass or force the automatic detection should it ever fail.
This patchset was tested on a SKL device with the DSP disabled and a WHL device with the DSP enabled. All 6 combinations of module parameters provided the expected behavior.
The SOF driver will use exactly the same mechanism, and add a mutual exclusion with the Skylake/SST driver to avoid having 3 drivers for the same PCI ID. Two is complicated enough.
Pierre-Louis Bossart (2): ALSA: HD-Audio: SKL+: abort probe if DSP is present and Skylake driver selected ALSA: HD-Audio: SKL+: force HDaudio legacy or SKL+ driver selection
Thanks for this work, I'd love to move forward in this direction for 4.21, then finally we'll solve the messy conflicts on SKL+.
Some comments have been already sent to each reply. But overall the changes look good.
Takashi