Re: [alsa-devel] [PATCH] ASoC: add RT5640 CODEC driver

On Tue, Jun 04, 2013 at 02:39:36PM +0800, Bard Liao wrote:

Actually, I don't know if I need to call "regcache_cache_only(rt5640->regmap, false);" here. We never call "regcache_cache_only(rt5640->regmap, true);" in the codec driver. I assume the cache_only flag is default false. If yes, I think I can remove "regcache_cache_only(rt5640->regmap, false);" from the code driver. If not, I will move it to the beginning of if (SND_SOC_BIAS_OFF == codec->dapm.bias_level) condition.

I'd actually put in code to enable cache only mode when you power off, that way when the support for the LDO enable GPIO is added it will not need to be re-added.