On 20-03-20, 17:01, Srinivas Kandagatla wrote:
On 20/03/2020 16:29, Pierre-Louis Bossart wrote:
Add new device as a child of the platform device, following the following hierarchy:
platform_device sdw_master_device sdw_slave0
Why can't we just remove the platform device layer here and add sdw_master_device directly?
In the case platform_device is the OF device your controller gets probed on.
My thinking on this is that drivers should not be directly creating sdw_master_device but it should be done by core as this device is for core to use and handle. Ideally I would love that sdw_master_device is created/handled by core, preferably this be handled as part of sdw_add_bus_master().
But Pierre is trying to solve the limitation of the devices given by ACPI and trying to add sdw_master_driver to handle that. I am not convinced that we should do that.