On Thu, Jun 29, 2017 at 04:43:38PM +0900, Takashi Sakamoto wrote:
Hi,
Hi Takashi,
+struct skl_debug *skl_debugfs_init(struct skl *skl) +{
- struct skl_debug *d;
- d = devm_kzalloc(&skl->pci->dev, sizeof(*d), GFP_KERNEL);
- if (!d)
return NULL;- /* create the root dir first */
- d->fs = debugfs_create_dir(KBUILD_MODNAME, NULL);
ALSA SoC part has a debugfs support. It adds "asoc" node into debugfs mount point and export "snd_soc_debugfs_root" symbol as a root node. I think it a better idea to collect relevant nodes into the place, rather than dispersing them.
Yes we can use that, but then this is very driver specific info, does it make sense to keep under framework 'asoc' ?
If we decide to use that, a more intuitive place might be "platform" rather than "asoc" which creates dependency on sound card creation which might happen much later.
for debug, I would like to avoid complexity and go with simple device approach...
As a quick glance, "snd_soc_skl" depends on "snd_soc_core", which exports the symbol. So no matter to dependencies.
$ lsmod | grep snd_soc_core snd_soc_core 233472 1 snd_soc_skl $ mount | grep debugfs debugfs on /sys/kernel/debug type debugfs (rw,relatime) $ sudo find /sys/kernel/debug/asoc /sys/kernel/debug/asoc /sys/kernel/debug/asoc/platforms /sys/kernel/debug/asoc/dais /sys/kernel/debug/asoc/codecs
$ cd mainline.git/ $ git grep snd_soc_debugfs_root sound/soc/soc-core.c | grep EXPORT sound/soc/soc-core.c:EXPORT_SYMBOL_GPL(snd_soc_debugfs_root);
Regards
Takashi Sakamoto