22 Apr
2015
22 Apr
'15
11:19 a.m.
On Wed, Apr 22, 2015 at 02:53:42PM +0900, Chanwoo Choi wrote:
Hi Richard,
@@ -1176,6 +1182,11 @@ static int arizona_extcon_probe(struct platform_device *pdev) break; } break;
- case WM8998:
- case WM1814:
info->micd_clamp = true;info->hpdet_ip = 2;What is meaning of '2'? I prefer to use the definition for '2'.
'2' is the version number of the hpdet ip block in silicon. We're already using it as a raw number '0', '1' or '2' all over extcon-arizona.c so changing it here would mean making other patches to the file that aren't really part of adding WM8998 support, so I'd prefer not to change that as a side-effect of adding WM8998.
Except for upper one comment, looks good to me.
Thanks, Chanwoo Choi