Re: [PATCH v4 2/6] cpufreq: do not open-code of_phandle_args_equal()

On 23-01-24, 15:13, Krzysztof Kozlowski wrote:

Use newly added of_phandle_args_equal() helper to compare two of_phandle_args.

Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org

---

Depends on previous of change.

include/linux/cpufreq.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index afda5f24d3dd..3cd06dafb04b 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -1149,8 +1149,7 @@ static inline int of_perf_domain_get_sharing_cpumask(int pcpu, const char *list_ if (ret < 0) continue;

• if (pargs->np == args.np && pargs->args_count == args.args_count &&
  

•     !memcmp(pargs->args, args.args, sizeof(args.args[0]) * args.args_count))
  

• if (of_phandle_args_equal(pargs, &args))
  cpumask_set_cpu(cpu, cpumask);
  
  

  of_node_put(args.np);

Acked-by: Viresh Kumar viresh.kumar@linaro.org