On Wed, 2011-10-19 at 13:13 +0100, Mark Brown wrote:
On Wed, Oct 19, 2011 at 12:51:35PM +0530, Ashish Chavan wrote:
BTW if in case, hardware designers reiterate to use STANDBY registers, will it suffice to only document this somewhere is the source?
The main thing is to make sure that the code is understandable and doesn't look buggy to visual inspection so yes, if there's adequate documentation that would be OK.
I see.
BTW today I received response from hardware designers and as expected, they are recommending usage of STANDBY registers instead of ENABLE/DISABLE registers. The main reason for this is that STANDBY registers are part of system controller which allows system power up/down in a controlled, pop free manner. Also, as per application note, STANDBY register bits are only effective if a particular IO (or ADC/DAC) is already enabled using enable/disable register bits. This is inline with my previous patch to support DAPM, i.e.
- All IOs and ADC/DAC are enabled using enable/disable register bits in probe() - STANDBY mode of all IOs and ADC/DAC is controlled by DAPM
I am thinking of re-posting the patch after adding above info somewhere.
Is there anything else that I need to take care of?